This site best when viewed with a modern standards-compliant browser. We recommend Firefox Get Firefox!.

Linux-HA project logo
Providing Open Source High-Availability Software for Linux and other OSes since 1999.

USA Flag UK Flag

Japanese Flag

Homepage

About Us

Contact Us

Legal Info

How To Contribute

Security Issues

18 August 2008 Heartbeat release 2.1.4 is now out Download it and install it!

11 October 2007 NEW educational HA/DR Blog hosted by Alan Robertson

9 April 2007 Check out the Cool Heartbeat Screencasts: Installation, Intro to the GUI Part of the Heartbeat Education project

Last site update:
2008-08-28 08:49:09

Heartbeat Open Issues

This page is formatted and updated according to the IssueTrackingWikiProtocol.

issue id

Summary: Memory allocation unification

Created by: -- Lars Marowsky-Brée 2004-03-02 05:01:02

LarsEllenberg asked on the linux-ha-dev mailing list how the memory allocation should be done inside heartbeat code, seeking a clarification of the rules. He points out that

  • that MALLOC is defined in every other C file, and not in some common header file and that the corresponding CALLOC and REALLOC are not defined anywhere,

  • that MALLOC or even malloc() is sometimes used directly, instead of the g_new function.

    The question boils down to: what is the preferred way of allocating memory in heartbeat - MALLOC, malloc, cl_malloc, g_new?

    LarsMarowskyBree agrees this is highly confusing, probably due to historical reasons, and a clarification of the rules and a cleanup of the legacy code is definetely needed. I think cl_malloc() should have the best chances.


  • CategoryIssue, CategoryOpenIssue

    issue id

    Summary: cl_logging daemon needs fixing

    Created by: -- Lars Marowsky-Brée 2004-03-02 05:11:17

    The cl_log code calls syslog(), which is about the last place in the core where we can block and kill our realtime performance.

    LarsEllenberg points out that the cl_log logging daemon is not implemented at all. He proposed to implement a double buffering scheme with a pre-allocated ring buffer. Using the non-blocking IPC code, this should solve the issue.

    LarsMarowskyBree says to go ahead - it would be nice if this single logging daemon was automatically used by all applications signing in with heartbeat or the crmd, ie if the logging daemon was shared among all cl_log() users.


    CategoryIssue, CategoryOpenIssue

    See also

    HeartbeatResolvedIssues, IssueTrackingWikiProtocol.